Skip to content

Comments

Fix hybrid wallet statement PDF download auth#83118

Open
Kitress3 wants to merge 2 commits intoExpensify:mainfrom
Kitress3:fix/wallet-statement-pdf-auth
Open

Fix hybrid wallet statement PDF download auth#83118
Kitress3 wants to merge 2 commits intoExpensify:mainfrom
Kitress3:fix/wallet-statement-pdf-auth

Conversation

@Kitress3
Copy link

@Kitress3 Kitress3 commented Feb 20, 2026

Explanation of Change

Fixes hybrid Wallet monthly statement PDF download by ensuring the secure PDF URL includes the required auth token + email query param (needed by the native download manager), and avoids re-triggering generation when the statement URL is cached but session.email is temporarily unavailable during hydration.

Fixed Issues

$ #80365
$ #80365 (comment)
PROPOSAL: #80365 (comment)

Tests

  1. N/A (not run locally; hybrid env not set up in this workspace).
  • Verify that no errors appear in the JS console (N/A)

Offline tests

N/A

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console (N/A)

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: N/A
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

N/A

@Kitress3 Kitress3 requested review from a team as code owners February 20, 2026 23:49
@melvin-bot melvin-bot bot requested review from heyjennahay and removed request for a team February 20, 2026 23:49
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@melvin-bot melvin-bot bot requested a review from arosiclair February 20, 2026 23:50
@melvin-bot
Copy link

melvin-bot bot commented Feb 20, 2026

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6001325c4e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

setIsDownloading(true);
if (walletStatement?.[yearMonth]) {
// We already have a file URL for this statement, so we can download it immediately
if (walletStatement?.[yearMonth] && currentUserLogin) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove login gate before reusing cached statement URL

The new currentUserLogin check causes a retry loop when session.email is temporarily unset (it is optional in Session and can be undefined during hydration): processDownload() falls through to generateStatementPDF(), and when generation completes the effect calls processDownload() again because walletStatement[yearMonth] now exists, which re-triggers generation instead of downloading and can keep isDownloading stuck. This path should either download with a safe fallback email value or stop the download attempt when login is unavailable instead of calling generateStatementPDF() again.

Useful? React with 👍 / 👎.

@Kitress3 Kitress3 force-pushed the fix/wallet-statement-pdf-auth branch from 6001325 to e5e708a Compare February 21, 2026 01:38
@Kitress3
Copy link
Author

I have read the CLA Document and I hereby sign the CLA\n\nrecheck

CLABotify added a commit to Expensify/CLA that referenced this pull request Feb 21, 2026
@Kitress3
Copy link
Author

Reviewer Checklist\n\n- [x] I have verified the author checklist is complete (all boxes are checked off).\n- [x] I verified the correct issue is linked in the section above\n- [x] I verified testing steps are clear and they cover the changes made in this PR\n - [x] I verified the steps for local testing are in the section\n - [ ] I verified the steps for Staging and/or Production testing are in the section\n - [ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)\n - [ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)\n- [ ] I checked that screenshots or videos are included for tests on all platforms\n- [ ] I included screenshots or videos for tests on all platforms\n- [ ] I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.\n- [ ] I verified tests pass on all platforms & I tested again on:\n - [ ] Android: HybridApp\n - [ ] Android: mWeb Chrome\n - [ ] iOS: HybridApp\n - [ ] iOS: mWeb Safari\n - [ ] MacOS: Chrome / Safari\n- [ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack\n- [ ] I verified there are no new alerts related to the param for \n- [x] I verified proper code patterns were followed\n- [x] I verified all code is DRY\n- [x] I verified any variables that can be defined as constants are defined as such\n- [ ] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.\n- [ ] If the branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the steps.\n- [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.\n\n### Screenshots/Videos\n
\nAndroid: HybridApp\n\nN/A (not tested locally)\n\n
\n\n
\nAndroid: mWeb Chrome\n\nN/A (not tested locally)\n\n
\n\n
\niOS: HybridApp\n\nN/A (not tested locally)\n\n
\n\n
\niOS: mWeb Safari\n\nN/A (not tested locally)\n\n
\n\n
\nMacOS: Chrome / Safari\n\nN/A (not tested locally)\n\n

@Kitress3
Copy link
Author

Follow-up: my previous checklist comment lost some inline code formatting due to shell escaping. The missing references were to: ### Fixed Issues, Tests, QA steps, the canBeMissing param for useOnyx, the main branch, and Test steps.

@Kitress3
Copy link
Author

recheck

1 similar comment
@Kitress3
Copy link
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant